tibia-fusion32/game
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bind acceptor to INADDR_ANY by default + set TCP_NODELAY on sockets

Browse Source 
- Binding the acceptor to the game address was troublesome with certain
setups, so it will now bind to INADDR_ANY by default. This behaviour
can be reverted by adding `-DBIND_ACCEPTOR_TO_GAME_ADDRESS=1` as a
compiler option.

- Setting TCP_NODELAY can help improving latency and reducing stutters
specially for players with higher ping. It was not in the original
binary, but it's probably worth it to have it enabled.
This commit is contained in:
fusion32 2026-01-14 18:18:49 -03:00
parent eeddc2b65a
commit c2cbe8e23b
1 changed files with 32 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
src/communication.cc
View File

@ -10,6 +10,7 @@
#include <arpa/inet.h>
#include <fcntl.h>
#include <netinet/in.h>
#include <netinet/tcp.h>
#include <poll.h>
#include <signal.h>
#include <sys/socket.h>
@ -1289,6 +1290,19 @@ void CommunicationThread(int Socket){
return;
}
// NOTE(fusion): In some systems, the accepted socket will inherit TCP_NODELAY
// from the acceptor, making this next call redundant then. Nevertheless it is
// probably better to set it anyways to be sure.
int NoDelay = 1;
if(setsockopt(Socket, IPPROTO_TCP, TCP_NODELAY, &NoDelay, sizeof(NoDelay)) == -1){
error("ConnectionThread: Failed to set TCP_NODELAY=1 on socket %d.\n", Socket);
if(close(Socket) == -1){
error("CommunicationThread: Fehler %d beim Schließen der Socket (3.5).\n", errno);
}
Connection->Free();
return;
}
sigset_t SignalSet;
sigfillset(&SignalSet);
sigprocmask(SIG_SETMASK, &SignalSet, NULL);
@ -1416,26 +1430,37 @@ bool OpenSocket(void){
Linger.l_onoff = 0;
Linger.l_linger = 0;
if(setsockopt(TCPSocket, SOL_SOCKET, SO_LINGER, &Linger, sizeof(Linger)) == -1){
error("LaunchServer: Socket wurde nicht auf LINGER=0 gesetzt.\n");
error("LaunchServer: Failed to set SO_LINGER=(0, 0): (%d) %s.\n",
errno, strerrordesc_np(errno));
return false;
}
int ReuseAddr = 1;
if(setsockopt(TCPSocket, SOL_SOCKET, SO_REUSEADDR, &ReuseAddr, sizeof(ReuseAddr)) == -1){
error("LaunchServer: Fehler %d bei setsockopt.\n", errno);
error("LaunchServer: Failed to set SO_REUSEADDR=1: (%d) %s.\n",
errno, strerrordesc_np(errno));
return false;
}
int NoDelay = 1;
if(setsockopt(TCPSocket, IPPROTO_TCP, TCP_NODELAY, &NoDelay, sizeof(NoDelay)) == -1){
error("LaunchServer: Failed to set TCP_NODELAY=1: (%d) %s.\n",
errno, strerrordesc_np(errno));
return false;
}
struct sockaddr_in ServerAddress = {};
ServerAddress.sin_family = AF_INET;
ServerAddress.sin_port = htons(GamePort);
#if BIND_ACCEPTOR_TO_GAME_ADDRESS
ServerAddress.sin_addr.s_addr = inet_addr(GameAddress);
#else
ServerAddress.sin_addr.s_addr = htonl(INADDR_ANY);
#endif
if(bind(TCPSocket, (struct sockaddr*)&ServerAddress, sizeof(ServerAddress)) == -1){
error("LaunchServer: Fehler %d bei bind.\n", errno);
print(1, "Bind Error Again -> Begin FloodBind :(\n");
while(bind(TCPSocket, (struct sockaddr*)&ServerAddress, sizeof(ServerAddress)) == -1){
DelayThread(1, 0);
}
error("LaunchServer: Failed to bind to acceptor to %s:%d: (%d) %s.\n",
inet_ntoa(ServerAddress.sin_addr), GamePort, errno, strerrordesc_np(errno));
return false;
}
if(listen(TCPSocket, 512) == -1){