tibia-fusion32/querymanager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gracefully handle no rows on "COUNT(*)" queries

Browse Source
This commit is contained in:
fusion32 2025-10-16 01:04:48 -03:00
parent 85b75f7737
commit b49d7de51c
1 changed files with 4 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/database_postgres.cc
View File

@ -1554,14 +1554,7 @@ bool GetAccountOnlineCharacters(TDatabase *Database, int AccountID, int *OnlineC
return false; return false;
} }
// NOTE(fusion): This is intended. A `SELECT COUNT(*)` query should always *OnlineCharacters = (PQntuples(Result) > 0 ? GetResultInt(Result, 0, 0) : 0);
// return something.
if(PQntuples(Result) == 0){
LOG_ERR("Query returned no rows");
return false;
}
*OnlineCharacters = GetResultInt(Result, 0, 0);
return true; return true;
} }
@ -2319,12 +2312,7 @@ bool GetAccountFailedLoginAttempts(TDatabase *Database, int AccountID, int TimeW
return false; return false;
} }
if(PQntuples(Result) == 0){ *FailedAttempts = (PQntuples(Result) > 0 ? GetResultInt(Result, 0, 0) : 0);
LOG_ERR("Query returned no rows");
return false;
}
*FailedAttempts = GetResultInt(Result, 0, 0);
return true; return true;
} }
@ -2352,12 +2340,7 @@ bool GetIPAddressFailedLoginAttempts(TDatabase *Database, int IPAddress, int Tim
return false; return false;
} }
if(PQntuples(Result) == 0){ *FailedAttempts = (PQntuples(Result) > 0 ? GetResultInt(Result, 0, 0) : 0);
LOG_ERR("Query returned no rows");
return false;
}
*FailedAttempts = GetResultInt(Result, 0, 0);
return true; return true;
} }
@ -2971,12 +2954,7 @@ bool GetNotationCount(TDatabase *Database, int CharacterID, int *Notations){
return false; return false;
} }
if(PQntuples(Result) == 0){ *Notations = (PQntuples(Result) > 0 ? GetResultInt(Result, 0, 0) : 0);
LOG_ERR("Query returned no rows");
return false;
}
*Notations = GetResultInt(Result, 0, 0);
return true; return true;
} }